Skip to content
  • Joe Perches's avatar
    8ee775f9
    staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros · 8ee775f9
    Joe Perches authored
    
    
    Macros with hidden flow control are bad form as the code path
    taken can be unexpected for the reader.
    
    Expand these in-place and remove the macros.
    
    Done with coccinelle script:
    
    @@
    expression chip;
    expression arg1;
    expression arg2;
    expression arg3;
    @@
    
    -	RTSX_WRITE_REG(chip, arg1, arg2, arg3);
    +	retval = rtsx_write_register(chip, arg1, arg2, arg3);
    +	if (retval) {
    +		rtsx_trace(chip);
    +		return retval;
    +	}
    
    @@
    expression chip;
    expression arg1;
    expression arg2;
    @@
    
    -	RTSX_READ_REG(chip, arg1, arg2);
    +	retval = rtsx_read_register(chip, arg1, arg2);
    +	if (retval) {
    +		rtsx_trace(chip);
    +		return retval;
    +	}
    
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    8ee775f9
    staging: rts5208: Remove RTSX_READ_REG and RTSX_WRITE_REG macros
    Joe Perches authored
    
    
    Macros with hidden flow control are bad form as the code path
    taken can be unexpected for the reader.
    
    Expand these in-place and remove the macros.
    
    Done with coccinelle script:
    
    @@
    expression chip;
    expression arg1;
    expression arg2;
    expression arg3;
    @@
    
    -	RTSX_WRITE_REG(chip, arg1, arg2, arg3);
    +	retval = rtsx_write_register(chip, arg1, arg2, arg3);
    +	if (retval) {
    +		rtsx_trace(chip);
    +		return retval;
    +	}
    
    @@
    expression chip;
    expression arg1;
    expression arg2;
    @@
    
    -	RTSX_READ_REG(chip, arg1, arg2);
    +	retval = rtsx_read_register(chip, arg1, arg2);
    +	if (retval) {
    +		rtsx_trace(chip);
    +		return retval;
    +	}
    
    Signed-off-by: default avatarJoe Perches <joe@perches.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Loading