Skip to content
  • YueHaibing's avatar
    89da2ba9
    soc: qcom: Fix llcc-qcom definitions to include · 89da2ba9
    YueHaibing authored
    
    
    commit 99356b03 ("soc: qcom: Make llcc-qcom a generic driver") move
    these out of llcc-qcom.h, make the building fails:
    
    drivers/edac/qcom_edac.c:86:40: error: array type has incomplete element type struct llcc_edac_reg_data
     static const struct llcc_edac_reg_data edac_reg_data[] = {
                                            ^~~~~~~~~~~~~
    drivers/edac/qcom_edac.c:87:3: error: array index in non-array initializer
      [LLCC_DRAM_CE] = {
       ^~~~~~~~~~~~
    drivers/edac/qcom_edac.c:87:3: note: (near initialization for edac_reg_data)
    drivers/edac/qcom_edac.c:88:3: error: field name not in record or union initializer
       .name = "DRAM Single-bit",
    ...
    drivers/edac/qcom_edac.c:169:51: warning: struct llcc_drv_data declared inside parameter
     list will not be visible outside of this definition or declaration
     qcom_llcc_clear_error_status(int err_type, struct llcc_drv_data *drv)
                                                       ^~~~~~~~~~~~~
    
    This patch move the needed definitions back to include.
    
    Reported-by: default avatarHulk Robot <hulkci@huawei.com>
    Fixes: 99356b03 ("soc: qcom: Make llcc-qcom a generic driver")
    Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
    Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    89da2ba9
    soc: qcom: Fix llcc-qcom definitions to include
    YueHaibing authored
    
    
    commit 99356b03 ("soc: qcom: Make llcc-qcom a generic driver") move
    these out of llcc-qcom.h, make the building fails:
    
    drivers/edac/qcom_edac.c:86:40: error: array type has incomplete element type struct llcc_edac_reg_data
     static const struct llcc_edac_reg_data edac_reg_data[] = {
                                            ^~~~~~~~~~~~~
    drivers/edac/qcom_edac.c:87:3: error: array index in non-array initializer
      [LLCC_DRAM_CE] = {
       ^~~~~~~~~~~~
    drivers/edac/qcom_edac.c:87:3: note: (near initialization for edac_reg_data)
    drivers/edac/qcom_edac.c:88:3: error: field name not in record or union initializer
       .name = "DRAM Single-bit",
    ...
    drivers/edac/qcom_edac.c:169:51: warning: struct llcc_drv_data declared inside parameter
     list will not be visible outside of this definition or declaration
     qcom_llcc_clear_error_status(int err_type, struct llcc_drv_data *drv)
                                                       ^~~~~~~~~~~~~
    
    This patch move the needed definitions back to include.
    
    Reported-by: default avatarHulk Robot <hulkci@huawei.com>
    Fixes: 99356b03 ("soc: qcom: Make llcc-qcom a generic driver")
    Signed-off-by: default avatarYueHaibing <yuehaibing@huawei.com>
    Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Loading