Skip to content
  • Bartosz Golaszewski's avatar
    adaff6d9
    net: ethernet: mtk-star-emac: simplify interrupt handling · adaff6d9
    Bartosz Golaszewski authored
    
    
    During development we tried to make the interrupt handling as fine-grained
    as possible with TX and RX interrupts being disabled/enabled independently
    and the counter registers reset from workqueue context.
    
    Unfortunately after thorough testing of current mainline, we noticed the
    driver has become unstable under heavy load. While this is hard to
    reproduce, it's quite consistent in the driver's current form.
    
    This patch proposes to go back to the previous approach of doing all
    processing in napi context with all interrupts masked in order to make the
    driver usable in mainline linux. This doesn't impact the performance on
    pumpkin boards at all and it's in line with what many ethernet drivers do
    in mainline linux anyway.
    
    At the same time we're adding a FIXME comment about the need to improve
    the interrupt handling.
    
    Fixes: 8c7bd5a4 ("net: ethernet: mtk-star-emac: new driver")
    Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    adaff6d9
    net: ethernet: mtk-star-emac: simplify interrupt handling
    Bartosz Golaszewski authored
    
    
    During development we tried to make the interrupt handling as fine-grained
    as possible with TX and RX interrupts being disabled/enabled independently
    and the counter registers reset from workqueue context.
    
    Unfortunately after thorough testing of current mainline, we noticed the
    driver has become unstable under heavy load. While this is hard to
    reproduce, it's quite consistent in the driver's current form.
    
    This patch proposes to go back to the previous approach of doing all
    processing in napi context with all interrupts masked in order to make the
    driver usable in mainline linux. This doesn't impact the performance on
    pumpkin boards at all and it's in line with what many ethernet drivers do
    in mainline linux anyway.
    
    At the same time we're adding a FIXME comment about the need to improve
    the interrupt handling.
    
    Fixes: 8c7bd5a4 ("net: ethernet: mtk-star-emac: new driver")
    Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Loading