Skip to content
  • Yonghong Song's avatar
    b7076592
    tools/bpf: fix core_reloc.c compilation error · b7076592
    Yonghong Song authored
    
    
    On my local machine, I have the following compilation errors:
    =====
      In file included from prog_tests/core_reloc.c:3:0:
      ./progs/core_reloc_types.h:517:46: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘fancy_char_ptr_t’
     typedef const char * const volatile restrict fancy_char_ptr_t;
                                                  ^
      ./progs/core_reloc_types.h:527:2: error: unknown type name ‘fancy_char_ptr_t’
        fancy_char_ptr_t d;
        ^
    =====
    
    I am using gcc 4.8.5. Later compilers may change their behavior not emitting the
    error. Nevertheless, let us fix the issue. "restrict" can be tested
    without typedef.
    
    Fixes: 9654e2ae ("selftests/bpf: add CO-RE relocs modifiers/typedef tests")
    Cc: Andrii Nakryiko <andriin@fb.com>
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
    b7076592
    tools/bpf: fix core_reloc.c compilation error
    Yonghong Song authored
    
    
    On my local machine, I have the following compilation errors:
    =====
      In file included from prog_tests/core_reloc.c:3:0:
      ./progs/core_reloc_types.h:517:46: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘fancy_char_ptr_t’
     typedef const char * const volatile restrict fancy_char_ptr_t;
                                                  ^
      ./progs/core_reloc_types.h:527:2: error: unknown type name ‘fancy_char_ptr_t’
        fancy_char_ptr_t d;
        ^
    =====
    
    I am using gcc 4.8.5. Later compilers may change their behavior not emitting the
    error. Nevertheless, let us fix the issue. "restrict" can be tested
    without typedef.
    
    Fixes: 9654e2ae ("selftests/bpf: add CO-RE relocs modifiers/typedef tests")
    Cc: Andrii Nakryiko <andriin@fb.com>
    Signed-off-by: default avatarYonghong Song <yhs@fb.com>
    Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
Loading