Skip to content
  • James Morse's avatar
    11b41626
    KVM: arm64: Skip more of the SError vaxorcism · 11b41626
    James Morse authored
    
    
    During __guest_exit() we need to consume any SError left pending by the
    guest so it doesn't contaminate the host. With v8.2 we use the
    ESB-instruction. For systems without v8.2, we use dsb+isb and unmask
    SError. We do this on every guest exit.
    
    Use the same dsb+isr_el1 trick, this lets us know if an SError is pending
    after the dsb, allowing us to skip the isb and self-synchronising PSTATE
    write if its not.
    
    This means SError remains masked during KVM's world-switch, so any SError
    that occurs during this time is reported by the host, instead of causing
    a hyp-panic.
    
    As we're benchmarking this code lets polish the layout. If you give gcc
    likely()/unlikely() hints in an if() condition, it shuffles the generated
    assembly so that the likely case is immediately after the branch. Lets
    do the same here.
    
    Signed-off-by: default avatarJames Morse <james.morse@arm.com>
    
    Changes since v2:
     * Added isb after the dsb to prevent an early read
    
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
    11b41626
    KVM: arm64: Skip more of the SError vaxorcism
    James Morse authored
    
    
    During __guest_exit() we need to consume any SError left pending by the
    guest so it doesn't contaminate the host. With v8.2 we use the
    ESB-instruction. For systems without v8.2, we use dsb+isb and unmask
    SError. We do this on every guest exit.
    
    Use the same dsb+isr_el1 trick, this lets us know if an SError is pending
    after the dsb, allowing us to skip the isb and self-synchronising PSTATE
    write if its not.
    
    This means SError remains masked during KVM's world-switch, so any SError
    that occurs during this time is reported by the host, instead of causing
    a hyp-panic.
    
    As we're benchmarking this code lets polish the layout. If you give gcc
    likely()/unlikely() hints in an if() condition, it shuffles the generated
    assembly so that the likely case is immediately after the branch. Lets
    do the same here.
    
    Signed-off-by: default avatarJames Morse <james.morse@arm.com>
    
    Changes since v2:
     * Added isb after the dsb to prevent an early read
    
    Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Loading