Skip to content
  • Eric W. Biederman's avatar
    bc54a5cd
    signal/parisc: Remove parisc specific definition of __ARCH_UAPI_SA_FLAGS · bc54a5cd
    Eric W. Biederman authored
    
    
    Randy Dunlap wrote:
    > On 11/27/20 10:43 AM, Randy Dunlap wrote:
    >
    > > on parisc, _SA_SIGGFAULT is undefined and causing build errors.
    > >
    > > commit 23acdc76
    > > Author: Peter Collingbourne <pcc@google.com>
    > > Date:   Thu Nov 12 18:53:34 2020 -0800
    > >
    > >     signal: clear non-uapi flag bits when passing/returning sa_flags
    > >
    > >
    > >
    > > _SA_SIGGFAULT is not used or defined anywhere else in the
    > > kernel source tree.
    >
    >
    > Here is the build error (although it should be obvious):
    >
    > ../kernel/signal.c: In function 'do_sigaction':
    > ../arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function)
    >    24 | #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
    >       |                              ^~~~~~~~~~~~~
    
    Stephen Rothwell pointed out:
    > _SA_SIGGFAULT was removed by commit
    >
    >   41f5a81c ("parisc: Drop HP-UX specific fcntl and signal flags")
    >
    > which was added to Linus' tree in v5.10-rc1.
    
    Solve this by removing the the parisc specific definition of
    __ARCH_UAPI_SA_FLAGS that was just added.
    
    Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
    Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
    Fixes: 23acdc76 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
    Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
    bc54a5cd
    signal/parisc: Remove parisc specific definition of __ARCH_UAPI_SA_FLAGS
    Eric W. Biederman authored
    
    
    Randy Dunlap wrote:
    > On 11/27/20 10:43 AM, Randy Dunlap wrote:
    >
    > > on parisc, _SA_SIGGFAULT is undefined and causing build errors.
    > >
    > > commit 23acdc76
    > > Author: Peter Collingbourne <pcc@google.com>
    > > Date:   Thu Nov 12 18:53:34 2020 -0800
    > >
    > >     signal: clear non-uapi flag bits when passing/returning sa_flags
    > >
    > >
    > >
    > > _SA_SIGGFAULT is not used or defined anywhere else in the
    > > kernel source tree.
    >
    >
    > Here is the build error (although it should be obvious):
    >
    > ../kernel/signal.c: In function 'do_sigaction':
    > ../arch/parisc/include/asm/signal.h:24:30: error: '_SA_SIGGFAULT' undeclared (first use in this function)
    >    24 | #define __ARCH_UAPI_SA_FLAGS _SA_SIGGFAULT
    >       |                              ^~~~~~~~~~~~~
    
    Stephen Rothwell pointed out:
    > _SA_SIGGFAULT was removed by commit
    >
    >   41f5a81c ("parisc: Drop HP-UX specific fcntl and signal flags")
    >
    > which was added to Linus' tree in v5.10-rc1.
    
    Solve this by removing the the parisc specific definition of
    __ARCH_UAPI_SA_FLAGS that was just added.
    
    Reported-by: default avatarRandy Dunlap <rdunlap@infradead.org>
    Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
    Fixes: 23acdc76 ("signal: clear non-uapi flag bits when passing/returning sa_flags")
    Signed-off-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Loading