Skip to content
  • Geert Uytterhoeven's avatar
    1f13aa4d
    ARM: 8973/1: Add missing newline terminator to kernel message · 1f13aa4d
    Geert Uytterhoeven authored
    
    
    Before commit 874f9c7d ("printk: create pr_<level> functions"),
    pr_*() calls without a trailing newline characters would be printed with
    a newline character appended, both on the console and in the output of
    the dmesg command.
    
    After that commit, no new line character is appended, and the output of
    the next pr_*() call of the same type may be appended:
    
        -No ATAGs?
        -hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
        +No ATAGs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
    
    While this commit has been reverted in commit a0cba217 ("Revert
    "printk: create pr_<level> functions""), it's still good practice to
    terminate kernel messages with newlines.
    
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
    1f13aa4d
    ARM: 8973/1: Add missing newline terminator to kernel message
    Geert Uytterhoeven authored
    
    
    Before commit 874f9c7d ("printk: create pr_<level> functions"),
    pr_*() calls without a trailing newline characters would be printed with
    a newline character appended, both on the console and in the output of
    the dmesg command.
    
    After that commit, no new line character is appended, and the output of
    the next pr_*() call of the same type may be appended:
    
        -No ATAGs?
        -hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
        +No ATAGs?hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint registers.
    
    While this commit has been reverted in commit a0cba217 ("Revert
    "printk: create pr_<level> functions""), it's still good practice to
    terminate kernel messages with newlines.
    
    Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
    Signed-off-by: default avatarRussell King <rmk+kernel@armlinux.org.uk>
Loading