Skip to content
  • Daniel Bristot de Oliveira's avatar
    6a82f42a
    trace/timerlat: Fix indentation on timerlat_main() · 6a82f42a
    Daniel Bristot de Oliveira authored
    Dan Carpenter reported that:
    
     The patch a955d7ea: "trace: Add timerlat tracer" from Jun 22,
     2021, leads to the following static checker warning:
    
    	kernel/trace/trace_osnoise.c:1400 timerlat_main()
    	warn: inconsistent indenting
    
    here:
      1389          while (!kthread_should_stop()) {
      1390                  now = ktime_to_ns(hrtimer_cb_get_time(&tlat->timer));
      1391                  diff = now - tlat->abs_period;
      1392
      1393                  s.seqnum = tlat->count;
      1394                  s.timer_latency = diff;
      1395                  s.context = THREAD_CONTEXT;
      1396
      1397                  trace_timerlat_sample(&s);
      1398
      1399  #ifdef CONFIG_STACKTRACE
      1400          if (osnoise_data.print_stack)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    	    This should be indented another tab?
    
      1401                  if (osnoise_data.print_stack <= time_to_us(diff))
      1402                          timerlat_dump_stack();
      1403  #endif /* CONFIG_STACKTRACE */
      1404
      1405                  tlat->tracing_thread = false;
      1406                  if (osnoise_data.stop_tracing_total)
      1407                          if (time_to_us(diff) >= osnoise_data.stop_tracing_total)
      1408                                  osnoise_stop_tracing();
      1409
      1410                  wait_next_period(tlat);
      1411          }
    
    And the static checker is right. Fix the indentation.
    
    Link: https://lkml.kernel.org/r/3d5d8c9258fbdcfa9d3c7362941b3d13a2a28d9d.1624986368.git.bristot@redhat.com
    
    
    
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
    Cc: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: linux-kernel@vger.kernel.org
    Fixes: a955d7ea ("trace: Add timerlat tracer")
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@redhat.com>
    Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
    6a82f42a
    trace/timerlat: Fix indentation on timerlat_main()
    Daniel Bristot de Oliveira authored
    Dan Carpenter reported that:
    
     The patch a955d7ea: "trace: Add timerlat tracer" from Jun 22,
     2021, leads to the following static checker warning:
    
    	kernel/trace/trace_osnoise.c:1400 timerlat_main()
    	warn: inconsistent indenting
    
    here:
      1389          while (!kthread_should_stop()) {
      1390                  now = ktime_to_ns(hrtimer_cb_get_time(&tlat->timer));
      1391                  diff = now - tlat->abs_period;
      1392
      1393                  s.seqnum = tlat->count;
      1394                  s.timer_latency = diff;
      1395                  s.context = THREAD_CONTEXT;
      1396
      1397                  trace_timerlat_sample(&s);
      1398
      1399  #ifdef CONFIG_STACKTRACE
      1400          if (osnoise_data.print_stack)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    	    This should be indented another tab?
    
      1401                  if (osnoise_data.print_stack <= time_to_us(diff))
      1402                          timerlat_dump_stack();
      1403  #endif /* CONFIG_STACKTRACE */
      1404
      1405                  tlat->tracing_thread = false;
      1406                  if (osnoise_data.stop_tracing_total)
      1407                          if (time_to_us(diff) >= osnoise_data.stop_tracing_total)
      1408                                  osnoise_stop_tracing();
      1409
      1410                  wait_next_period(tlat);
      1411          }
    
    And the static checker is right. Fix the indentation.
    
    Link: https://lkml.kernel.org/r/3d5d8c9258fbdcfa9d3c7362941b3d13a2a28d9d.1624986368.git.bristot@redhat.com
    
    
    
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
    Cc: Dan Carpenter <dan.carpenter@oracle.com>
    Cc: linux-kernel@vger.kernel.org
    Fixes: a955d7ea ("trace: Add timerlat tracer")
    Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarDaniel Bristot de Oliveira <bristot@redhat.com>
    Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
Loading