Skip to content
  • Ian Rogers's avatar
    4584f084
    perf parse: Fix potential memory leak when handling tracepoint errors · 4584f084
    Ian Rogers authored
    
    
    An error may be in place when tracepoint_error is called, use
    parse_events__handle_error to avoid a memory leak and to capture the
    first and last error. Error detected by LLVM's libFuzzer using the
    following event:
    
    $ perf stat -e 'msr/event/,f:e'
    event syntax error: 'msr/event/,f:e'
                         \___ can't access trace events
    
    Error:  No permissions to read /sys/kernel/debug/tracing/events/f/e
    Hint:   Try 'sudo mount -o remount,mode=755 /sys/kernel/debug/tracing/'
    
    Initial error:
    event syntax error: 'msr/event/,f:e'
                                    \___ no value assigned for term
    Run 'perf list' for a list of valid events
    
     Usage: perf stat [<options>] [<command>]
    
        -e, --event <event>   event selector. use 'perf list' to list available events
    
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: clang-built-linux@googlegroups.com
    Link: http://lore.kernel.org/lkml/20191120180925.21787-1-irogers@google.com
    
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    4584f084
    perf parse: Fix potential memory leak when handling tracepoint errors
    Ian Rogers authored
    
    
    An error may be in place when tracepoint_error is called, use
    parse_events__handle_error to avoid a memory leak and to capture the
    first and last error. Error detected by LLVM's libFuzzer using the
    following event:
    
    $ perf stat -e 'msr/event/,f:e'
    event syntax error: 'msr/event/,f:e'
                         \___ can't access trace events
    
    Error:  No permissions to read /sys/kernel/debug/tracing/events/f/e
    Hint:   Try 'sudo mount -o remount,mode=755 /sys/kernel/debug/tracing/'
    
    Initial error:
    event syntax error: 'msr/event/,f:e'
                                    \___ no value assigned for term
    Run 'perf list' for a list of valid events
    
     Usage: perf stat [<options>] [<command>]
    
        -e, --event <event>   event selector. use 'perf list' to list available events
    
    Signed-off-by: default avatarIan Rogers <irogers@google.com>
    Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
    Cc: Andi Kleen <ak@linux.intel.com>
    Cc: Jin Yao <yao.jin@linux.intel.com>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Mark Rutland <mark.rutland@arm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Stephane Eranian <eranian@google.com>
    Cc: clang-built-linux@googlegroups.com
    Link: http://lore.kernel.org/lkml/20191120180925.21787-1-irogers@google.com
    
    
    Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
Loading