Skip to content
  • Darrick J. Wong's avatar
    45068063
    xfs: fix incorrect root dquot corruption error when switching group/project quota types · 45068063
    Darrick J. Wong authored
    
    
    While writing up a regression test for broken behavior when a chprojid
    request fails, I noticed that we were logging corruption notices about
    the root dquot of the group/project quota file at mount time when
    testing V4 filesystems.
    
    In commit afeda600, I was trying to improve ondisk dquot validation
    by making sure that when we load an ondisk dquot into memory on behalf
    of an incore dquot, the dquot id and type matches.  Unfortunately, I
    forgot that V4 filesystems only have two quota files, and can switch
    that file between group and project quota types at mount time.  When we
    perform that switch, we'll try to load the default quota limits from the
    root dquot prior to running quotacheck and log a corruption error when
    the types don't match.
    
    This is inconsequential because quotacheck will reset the second quota
    file as part of doing the switch, but we shouldn't leave scary messages
    in the kernel log.
    
    Fixes: afeda600 ("xfs: validate ondisk/incore dquot flags")
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
    Reviewed-by: default avatarChandan Babu R <chandanrlinux@gmail.com>
    45068063
    xfs: fix incorrect root dquot corruption error when switching group/project quota types
    Darrick J. Wong authored
    
    
    While writing up a regression test for broken behavior when a chprojid
    request fails, I noticed that we were logging corruption notices about
    the root dquot of the group/project quota file at mount time when
    testing V4 filesystems.
    
    In commit afeda600, I was trying to improve ondisk dquot validation
    by making sure that when we load an ondisk dquot into memory on behalf
    of an incore dquot, the dquot id and type matches.  Unfortunately, I
    forgot that V4 filesystems only have two quota files, and can switch
    that file between group and project quota types at mount time.  When we
    perform that switch, we'll try to load the default quota limits from the
    root dquot prior to running quotacheck and log a corruption error when
    the types don't match.
    
    This is inconsequential because quotacheck will reset the second quota
    file as part of doing the switch, but we shouldn't leave scary messages
    in the kernel log.
    
    Fixes: afeda600 ("xfs: validate ondisk/incore dquot flags")
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarBrian Foster <bfoster@redhat.com>
    Reviewed-by: default avatarChandan Babu R <chandanrlinux@gmail.com>
Loading