Skip to content
  • Eric Dumazet's avatar
    dda9d57e
    fm10k: remove ndo_poll_controller · dda9d57e
    Eric Dumazet authored
    
    
    As diagnosed by Song Liu, ndo_poll_controller() can
    be very dangerous on loaded hosts, since the cpu
    calling ndo_poll_controller() might steal all NAPI
    contexts (for all RX/TX queues of the NIC). This capture
    lasts for unlimited amount of time, since one
    cpu is generally not able to drain all the queues under load.
    
    fm10k uses NAPI for TX completions, so we better let core
    networking stack call the napi->poll() to avoid the capture.
    
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    dda9d57e
    fm10k: remove ndo_poll_controller
    Eric Dumazet authored
    
    
    As diagnosed by Song Liu, ndo_poll_controller() can
    be very dangerous on loaded hosts, since the cpu
    calling ndo_poll_controller() might steal all NAPI
    contexts (for all RX/TX queues of the NIC). This capture
    lasts for unlimited amount of time, since one
    cpu is generally not able to drain all the queues under load.
    
    fm10k uses NAPI for TX completions, so we better let core
    networking stack call the napi->poll() to avoid the capture.
    
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Loading