Skip to content
  • Tom Rix's avatar
    780d815d
    media: tw5864: check status of tw5864_frameinterval_get · 780d815d
    Tom Rix authored
    
    
    clang static analysis reports this problem
    
    tw5864-video.c:773:32: warning: The left expression of the compound
      assignment is an uninitialized value.
      The computed value will also be garbage
            fintv->stepwise.max.numerator *= std_max_fps;
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
    
    stepwise.max is set with frameinterval, which comes from
    
    	ret = tw5864_frameinterval_get(input, &frameinterval);
    	fintv->stepwise.step = frameinterval;
    	fintv->stepwise.min = frameinterval;
    	fintv->stepwise.max = frameinterval;
    	fintv->stepwise.max.numerator *= std_max_fps;
    
    When tw5864_frameinterval_get() fails, frameinterval is not
    set. So check the status and fix another similar problem.
    
    Signed-off-by: default avatarTom Rix <trix@redhat.com>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    780d815d
    media: tw5864: check status of tw5864_frameinterval_get
    Tom Rix authored
    
    
    clang static analysis reports this problem
    
    tw5864-video.c:773:32: warning: The left expression of the compound
      assignment is an uninitialized value.
      The computed value will also be garbage
            fintv->stepwise.max.numerator *= std_max_fps;
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
    
    stepwise.max is set with frameinterval, which comes from
    
    	ret = tw5864_frameinterval_get(input, &frameinterval);
    	fintv->stepwise.step = frameinterval;
    	fintv->stepwise.min = frameinterval;
    	fintv->stepwise.max = frameinterval;
    	fintv->stepwise.max.numerator *= std_max_fps;
    
    When tw5864_frameinterval_get() fails, frameinterval is not
    set. So check the status and fix another similar problem.
    
    Signed-off-by: default avatarTom Rix <trix@redhat.com>
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Loading