Skip to content

Draft: Bug fixes for PingTransponders Service

Dylan Kriegman (SIO CORDC) requested to merge dev/cordc/ping_transponder_fixes into devel

Breaking Changes

PingTranspondersReply message changed field timeout_ms to timeout_sec

New Features / Improvements

PingTransponders service now works and publishes the PingTranspondersReply correctly

Bugfixes

By casting the timeout to an integer there will no longer be a decimal place in the CCPDT NMEA string resolving the bug where the modem could not parse the decimal place.

Updating the PingTranspondersReply message format to have timeout_sec mirrors the latest update to the PingTransponders service which has timeout_sec and allows devel version to work which passes the value into the PingTranspondersReply as though it is timeout_sec when it needs to be updated to timeout_sec (is timeout_ms prior to this change).

If I am not a WHOI employee, I agree to the terms in the WHOI Contributor Agreement (CONTRIBUTING.md) in this repository.

Edited by Dylan Kriegman (SIO CORDC)

Merge request reports