Skip to content
  • Hans Verkuil's avatar
    7124ae48
    media: s5k5baf: drop 'data' field in struct s5k5baf_fw · 7124ae48
    Hans Verkuil authored
    
    
    struct s5k5baf_fw ends with this:
    
           struct {
                   u16 id;
                   u16 offset;
           } seq[0];
           u16 data[];
    };
    
    which is rather confusing and can cause gcc warnings:
    
    s5k5baf.c: In function 's5k5baf_load_setfile.isra':
    s5k5baf.c:390:13: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct <anonymous>[0]' [-Wzero-length-bounds]
      390 |   if (f->seq[i].offset + d <= end)
          |       ~~~~~~^~~
    
    It turns out that 'data[]' is used in only one place and it can
    easily be replaced by &fw->seq[0].id and 'seq[0]' can be replaced by
    'seq[]'.
    
    This is both more readable and solved that warnings.
    
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Kyungmin Park <kyungmin.park@samsung.com>
    Cc: Sylwester Nawrocki <snawrocki@kernel.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
    7124ae48
    media: s5k5baf: drop 'data' field in struct s5k5baf_fw
    Hans Verkuil authored
    
    
    struct s5k5baf_fw ends with this:
    
           struct {
                   u16 id;
                   u16 offset;
           } seq[0];
           u16 data[];
    };
    
    which is rather confusing and can cause gcc warnings:
    
    s5k5baf.c: In function 's5k5baf_load_setfile.isra':
    s5k5baf.c:390:13: warning: array subscript 65535 is outside the bounds of an interior zero-length array 'struct <anonymous>[0]' [-Wzero-length-bounds]
      390 |   if (f->seq[i].offset + d <= end)
          |       ~~~~~~^~~
    
    It turns out that 'data[]' is used in only one place and it can
    easily be replaced by &fw->seq[0].id and 'seq[0]' can be replaced by
    'seq[]'.
    
    This is both more readable and solved that warnings.
    
    Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
    Cc: Kyungmin Park <kyungmin.park@samsung.com>
    Cc: Sylwester Nawrocki <snawrocki@kernel.org>
    Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Loading