Skip to content
  • Ben Dooks (Codethink)'s avatar
    9a4c2274
    pinctrl: artpec6: fix __iomem on reg in set · 9a4c2274
    Ben Dooks (Codethink) authored
    
    
    The artpec6_pconf_set should have marked reg as __iomem,
     which ends up making sparse complain about address
    space conversions. Add the __iomem to silence the
    following warnings:
    
    drivers/pinctrl/pinctrl-artpec6.c:814:13: warning: incorrect type in assignment (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:814:13:    expected unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:814:13:    got void [noderef] <asn:2> *
    drivers/pinctrl/pinctrl-artpec6.c:825:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:825:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:825:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:827:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:827:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:827:25:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:837:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:837:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:837:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:840:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:840:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:840:25:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:850:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:850:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:850:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:853:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:853:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:853:25:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:864:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:864:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:864:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:867:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:867:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:867:25:    got unsigned int *reg
    
    Signed-off-by: default avatarBen Dooks (Codethink) <ben.dooks@codethink.co.uk>
    Link: https://lore.kernel.org/r/20191218101602.2442868-1-ben.dooks@codethink.co.uk
    
    
    [Changed unsigned int -> void for the reg pointer]
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    9a4c2274
    pinctrl: artpec6: fix __iomem on reg in set
    Ben Dooks (Codethink) authored
    
    
    The artpec6_pconf_set should have marked reg as __iomem,
     which ends up making sparse complain about address
    space conversions. Add the __iomem to silence the
    following warnings:
    
    drivers/pinctrl/pinctrl-artpec6.c:814:13: warning: incorrect type in assignment (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:814:13:    expected unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:814:13:    got void [noderef] <asn:2> *
    drivers/pinctrl/pinctrl-artpec6.c:825:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:825:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:825:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:827:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:827:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:827:25:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:837:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:837:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:837:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:840:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:840:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:840:25:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:850:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:850:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:850:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:853:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:853:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:853:25:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:864:34: warning: incorrect type in argument 1 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:864:34:    expected void const volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:864:34:    got unsigned int *reg
    drivers/pinctrl/pinctrl-artpec6.c:867:25: warning: incorrect type in argument 2 (different address spaces)
    drivers/pinctrl/pinctrl-artpec6.c:867:25:    expected void volatile [noderef] <asn:2> *addr
    drivers/pinctrl/pinctrl-artpec6.c:867:25:    got unsigned int *reg
    
    Signed-off-by: default avatarBen Dooks (Codethink) <ben.dooks@codethink.co.uk>
    Link: https://lore.kernel.org/r/20191218101602.2442868-1-ben.dooks@codethink.co.uk
    
    
    [Changed unsigned int -> void for the reg pointer]
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Loading